Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Create webpack stats target directory if needed and accept boolean flag #14690

Merged
merged 2 commits into from Apr 22, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Apr 22, 2021

Issue: -

What I did

Instead of writeFile this uses outputFile so that it will create directories if needed.
With this change, --webpack-stats-json won't require a value anymore. If the flag is present with no value (true), it will use the outputDir as its value.
Also I updated the args definitions to correctly use <> (required) and [] (optional)

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@shilman shilman changed the title Create webpack stats target directory if not exists and accept boolean flag Build: Create webpack stats target directory if not exists and accept boolean flag Apr 22, 2021
@shilman shilman changed the title Build: Create webpack stats target directory if not exists and accept boolean flag Build: Create webpack stats target directory if needed and accept boolean flag Apr 22, 2021
@shilman shilman merged commit 560b8d6 into next Apr 22, 2021
@shilman shilman deleted the better-webpack-stats-out branch April 22, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants