Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Remove babel-loader and @babel/core peer deps #14689

Merged
merged 1 commit into from Apr 22, 2021
Merged

Docs: Remove babel-loader and @babel/core peer deps #14689

merged 1 commit into from Apr 22, 2021

Conversation

gaetanmaisse
Copy link
Member

@gaetanmaisse gaetanmaisse commented Apr 22, 2021 •
edited

Issue: #13183

What I did

Docs:

  • Remove babel-loader peer dep as babel-loader is required in the context of builder-webpack4 so there is no need to have it as a dep.
  • Remove @babel/core peer dep as it is already there as regular dep

How to test

  • As these changes are quite critical they are somehow covered by all the examples + chromatic + E2E tests

@gaetanmaisse
refactor(addon-docs): remove babel-loader peer dep
16a5deb 
`babel-loader` is required in the context of `builder-webpack4` so there is no need to have it as a dep.
@gaetanmaisse gaetanmaisse added the maintenance User-facing maintenance tasks label Apr 22, 2021
@gaetanmaisse gaetanmaisse marked this pull request as ready for review April 22, 2021 06:56
@gaetanmaisse gaetanmaisse requested a review from a team April 22, 2021 06:56
shilman
shilman approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. should we patch this into 6.2?

@shilman shilman merged commit 642c17f into next Apr 22, 2021
@shilman shilman deleted the rework-and-clean-deps branch April 22, 2021 10:27
@gaetanmaisse
Copy link
Member Author

The real issue with babel-loader was fixed a while ago and this PR is just some maintenance/cosmetic improvements so it's not mandatory to backport them to 6.2 I guess.

@shilman shilman mentioned this pull request Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaetanmaisse @shilman