Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Storybook's built-in accessibility icon for VisionDeficiency tab. #14681

Conversation

JonathanTR
Copy link

@JonathanTR JonathanTR commented Apr 21, 2021

Issue: The mirror icon does not accurately reflect the Vision Deficiency tool's purpose in the toolbar.

What I did

Changed the icon for this a11y feature to Storybook's built-in "accessibility" icon.

Old:
Screen Shot 2021-04-21 at 11 48 29 AM

New:
Screen Shot 2021-04-21 at 12 00 19 PM

How to test

  • Is this testable with Jest or Chromatic screenshots? No.
  • Does this need a new example in the kitchen sink apps? No.
  • Does this need an update to the documentation? No.

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman added ui maintenance User-facing maintenance tasks labels Apr 21, 2021
@domyen
Copy link
Member

domyen commented Apr 21, 2021

lgtm thanks Jonathan 👍

@domyen domyen assigned shilman and unassigned domyen Apr 21, 2021
@shilman shilman merged commit 88954b6 into storybookjs:next Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants