Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Rename react template files to jsx #14650

Merged
merged 1 commit into from Apr 19, 2021
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 19, 2021

Issue: N/A

What I did

Renamed all JSX files in the react CLI template from .js to .jsx

This is technically more correct, but the primary motivation is to help support community builders (e.g. storybook-builder-vite) whose build systems require .jsx to add JSX support.

How to test

npm init @vitejs/app # choose react
cd vite-project
/path/to/storybook/lib/cli/bin/index.js init --builder storybook-addon-vite

@shilman shilman added maintenance User-facing maintenance tasks cli labels Apr 19, 2021
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 9220d54 into next Apr 19, 2021
@shilman shilman deleted the cli-rename-template-files-to-jsx branch April 19, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants