Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Support Ivy addon #14649

Merged
merged 1 commit into from Apr 19, 2021
Merged

Angular: Support Ivy addon #14649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions app/angular/src/client/preview/angular-beta/RendererService.ts
View file
Open in desktop
Expand Up @@ -80,6 +80,25 @@ export class RendererService {
return;
}

try {
// Clear global Angular component cache in order to be able to re-render the same component across multiple stories
//
// References:
// https://github.com/angular/angular-cli/blob/master/packages/angular_devkit/build_angular/src/webpack/plugins/hmr/hmr-accept.ts#L50
// https://github.com/angular/angular/blob/2ebe2bcb2fe19bf672316b05f15241fd7fd40803/packages/core/src/render3/jit/module.ts#L377-L384
// eslint-disable-next-line global-require
const resetCompiledComponents = require('@angular/core').ɵresetCompiledComponents;
resetCompiledComponents();
} catch (e) {
/**
* noop catch
* This means angular removed or modified ɵresetCompiledComponents
*
* Probably, they added a clearCache mechanism to platform.destroy() and
* we can simply remove this in case no errors are thrown during runtime
*/
}

// Complete last BehaviorSubject and set a new one for the current module
if (this.storyProps$) {
this.storyProps$.complete();
Expand Down