Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: set the @ViewChild with a non-empty value in StorybookWrapperComponent #14586

Merged
merged 1 commit into from Apr 14, 2021
Merged

Angular: set the @ViewChild with a non-empty value in StorybookWrapperComponent #14586

merged 1 commit into from Apr 14, 2021

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Apr 13, 2021 •
edited

Issue: #14575. maybe other ??? 🤔

What I did

Fix the error :

Unhandled Promise rejection: Can't construct a query for the property "storyComponentElementRef" of "StorybookWrapperComponent" since the query selector wasn't defined. ; Zone: ; Task: Promise.then ; Value: Error: Can't construct a query for the property "storyComponentElementRef" of "StorybookWrapperComponent" since the query selector wasn't defined.
which appears on angular v11 once the ngcc command is executed

How to test

  • Is this testable with Jest or Chromatic screenshots?

hardly :/ I don't know how to do it

  • Does this need a new example in the kitchen sink apps?

nope

  • Does this need an update to the documentation?

nope

If your answer is yes to any of these, please make sure to include it in your PR.

@ThibaudAV
fix(angular): set the @ViewChild with a non-empty value in StorybookW…
d72337e 
…rapperComponent

Fix the error :
> Unhandled Promise rejection: Can't construct a query for the property "storyComponentElementRef" of "StorybookWrapperComponent" since the query selector wasn't defined. ; Zone: <root> ; Task: Promise.then ; Value: Error: Can't construct a query for the property "storyComponentElementRef" of "StorybookWrapperComponent" since the query selector wasn't defined.

which appears on angular v11 once the ngcc command is executed
@ThibaudAV ThibaudAV marked this pull request as ready for review April 13, 2021 19:25
shilman
shilman approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @ThibaudAV 🙏

@shilman shilman merged commit f690c03 into next Apr 14, 2021
@shilman shilman deleted the angular/fix-StorybookWrapperComponent branch April 14, 2021 01:28
@shilman shilman mentioned this pull request Apr 14, 2021
Closed
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Apr 22, 2021
shilman added a commit that referenced this pull request Apr 23, 2021
@shilman
Merge pull request #14586 from storybookjs/angular/fix-StorybookWrapp…
b63e6ba 
…erComponent

Angular: set the @ViewChild with a non-empty value in StorybookWrapperComponent
@BoxPistols BoxPistols mentioned this pull request Feb 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThibaudAV @shilman