Core: Fix URL handling in Firefox #14556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When opening a storybook build in a local filesystem with Firefox, an error occurs.
The error indicates that some string like
null/Users/raon0211/dev/repo-name/storybook-build/iframe.html
was passed to the constructor of the native URL class.This is because when Firefox parses URLs with protocol
file:
(e.g.file:///Users/raon0211/dev/repo-name/storybook-build/index.html
), the resulting url object has origin"null"
. (See this bugzilla link.)As documented in MDN, the
origin
of URL objects is browser dependent when the url has thefile:
protocol.What I did
I used the browser-independent
protocol
andhost
instead oforigin
to fix the problem.How to test
This issue only occurs in Firefox.