CLI: Fix prerelease upgrade #14529
Merged
CLI: Fix prerelease upgrade #14529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
cli
patch:yes
shilman
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -
Currently
sb upgrade --prereleasecan upgrades to the newest release, which is nearly always the latest prerelease. However, when I release a patch release and don't immediately release a prerelease afterwards, it will upgrade to the patch release instead, which is incorrect behavior.What I did
Now
npm-check-updatessupports a--target greatestflag. The "greatest" release will nearly always be the prerelease, and in the cases that it's not, it's still the intended behavior.self-merging @tooppaaa
How to test
Run the CLI on an old project