Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Generate manager cache in smoke test, but don't use/clear any cache #13784

Merged
merged 3 commits into from Feb 1, 2021

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Feb 1, 2021

Issue: -
Discussion: #13737

What I did

When running with --smoke-test, currently no manager cache is used, created or cleared. However, sometimes it's beneficial to be able to prepare (generate) a cached manager without actually starting Storybook, for example when preparing a Docker image with embedded manager cache. This change makes --smoke-test cache the manager it built like normal, but won't use or clear any cache it finds as was intended in #13266.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman changed the title Generate manager cache when running smoke test, but don't use or clear any cache Core: Generate manager cache in smoke test, but don't use or clear any cache Feb 1, 2021
@shilman shilman changed the title Core: Generate manager cache in smoke test, but don't use or clear any cache Core: Generate manager cache in smoke test, but don't use/clear any cache Feb 1, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghengeveld Unit test are failing, can you fix?

@phated
Copy link
Contributor

phated commented Feb 1, 2021

@shilman I believe unit tests are failing because an old, bad cache is used when a new cache is not found. I submitted a PR at #13752 but it hasn't been reviewed/merged.

@phated
Copy link
Contributor

phated commented Feb 1, 2021

@ghengeveld That PR has landed, but I think you need to rebase master to get that action base to run 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants