Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marko: migrate to TS #13449

Merged
merged 1 commit into from Jan 13, 2021
Merged

Marko: migrate to TS #13449

merged 1 commit into from Jan 13, 2021

Conversation

gaetanmaisse
Copy link
Member

Issue: Part of #5030

What I did

Fastly migrate @storybook/marko to TS as I want to close the big TS Migration Issue before moving to improve types of @storybook/core.

How to test

  • CI should be 馃煝 , we rely only on examples as there is no E2E for Marko. According to the comment in e2e-config:

// TODO: not working on start-storybook
// - Marko CLI is failing with Node 12 and looks to work with Node 10
// - Demo components of @storybook/marko must be updated
// - Marko Story templates of @storybook/cli must be updated

@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks app: marko labels Dec 14, 2020
@gaetanmaisse gaetanmaisse mentioned this pull request Dec 14, 2020
Closed
@gaetanmaisse gaetanmaisse marked this pull request as ready for review December 14, 2020 20:54
@gaetanmaisse gaetanmaisse requested a review from a team December 14, 2020 20:54
ThibaudAV
ThibaudAV approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@ThibaudAV ThibaudAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discover new ones every day 馃ぃ

@gaetanmaisse gaetanmaisse merged commit a223286 into next Jan 13, 2021
@gaetanmaisse gaetanmaisse deleted the tech/migrate-marko-to-ts branch January 13, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaudAV ThibaudAV ThibaudAV approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaetanmaisse @ThibaudAV