Marionette: migrate to TS #13448
Merged
Marionette: migrate to TS #13448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetanmaisse
commented
Dec 14, 2020
| @@ -8,10 +8,10 @@ const allMarionetteViewConstructors = [ | |||
| ]; | |||
| const viewConstructorsSupportedByMarionette = allMarionetteViewConstructors | |||
| .filter((constructorName) => constructorName in Marionette) | |||
| .map((constructorName) => Marionette[constructorName]); | |||
| .map((constructorName) => (Marionette as any)[constructorName]); | |||
There was a problem hiding this comment.
I tried to find the correct type but it's too 馃く for a non-marionette user.
gaetanmaisse
commented
Dec 14, 2020
Comment on lines
+18
to
+20
| export const storiesOf = (...args: any) => | ||
| clientApi.storiesOf(...args).addParameters({ framework }); | ||
| export const load = (...args: any) => coreLoad(...args, framework); |
There was a problem hiding this comment.
Will be properly type as soon as I will rework some @storybook/core types
gaetanmaisse
commented
Dec 14, 2020
Comment on lines
+4
to
+6
| export function webpack(config: Configuration) { | ||
| return config; | ||
| } |
There was a problem hiding this comment.
Not sure we need this but I didn't want to make changes to production code other than a simple TS migration.
gaetanmaisse
force-pushed
the
tech/migrate-marionnette-to-ts
branch
from
2798d1e
to
a3d00fc
Compare
gaetanmaisse
force-pushed
the
tech/migrate-marionnette-to-ts
branch
from
a3d00fc
to
2150e27
Compare
gaetanmaisse
force-pushed
the
tech/migrate-marionnette-to-ts
branch
from
2150e27
to
3f67f70
Compare
|
I think we are good to go with this one @ndelangen @shilman, not sure the diffs in chromatic are relevant/related to this PR. |
ThibaudAV
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Part of #5030
What I did
Fastly migrate
@storybook/marionetteto TS as I want to close the big TS Migration Issue before moving to improve types of@storybook/core.How to test