CLI: Fix stories path in Introduction.stories.mdx #13368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path where Storybook generates the boilerplate changed from `storybook-examples` to `stories` in https://github.com/storybookjs/storybook/blob/next/lib/cli/src/helpers.ts#L209-L214, but wasn't updated in the `Introduction.stories.mdx` (which also happens to correspond with the old `welcome.mdx` file that doesn't exist anymore). With this change, we can prevent people from getting confused by not finding the `storybook-examples` folder.
HorusGoul
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
shilman
added
bug
cli
patch:yes
shilman
approved these changes
Dec 4, 2020
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Dec 4, 2020
CLI: Fix stories path in Introduction.stories.mdx
Glad to be able to help! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The path where Storybook generates the boilerplate changed from
storybook-examplestostoriesin https://github.com/storybookjs/storybook/blob/next/lib/cli/src/helpers.ts#L209-L214 but wasn't updated in theIntroduction.stories.mdx(which also happens to correspond with the oldwelcome.mdxfile that doesn't exist anymore).With this change, we can prevent people from getting confused by not finding the
storybook-examplesfolder.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.