Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-storyshots: Add React as peer dependency #13343

Merged
merged 1 commit into from Dec 2, 2020
Merged

Addon-storyshots: Add React as peer dependency #13343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/storyshots/storyshots-core/package.json
View file
Open in desktop
Expand Up @@ -68,6 +68,7 @@
"jest-vue-preprocessor": "^1.5.0"
},
"peerDependencies": {
"@storybook/react": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be marked as optional

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR please? 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, just saw it. Nvm!

"@storybook/vue": "*",
"jest-preset-angular": "*",
"jest-vue-preprocessor": "*",
Expand Down