Storyshots: Fix missing done attribute on type definition
#13341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyrichardson
requested review from
igor-dv and
thomasbertet
as code owners
shilman
requested changes
Dec 1, 2020
There was a problem hiding this comment.
Thank you for the fix @andyrichardson. Mind retargeting this PR to next?
|
@shilman done 👍 |
shilman
added
addon: storyshots
bug
patch:yes
shilman
changed the title
done attribute on type definitiondone attribute on type definition
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Dec 4, 2020
Storyshots: Fix missing `done` attribute on type definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
Added missing type definition - https://github.com/storybookjs/storybook/blob/master/addons/storyshots/storyshots-core/src/api/snapshotsTestsTemplate.ts#L16
How to test
N/A