Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Only apply express.json() middleware to /runtime-error route #13295

Merged
merged 1 commit into from Nov 26, 2020
Merged

Core: Only apply express.json() middleware to /runtime-error route #13295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions lib/core/src/server/dev-server.ts
View file
Open in desktop
Expand Up @@ -281,10 +281,11 @@ const startManager = async ({
next();
});

router.post('/runtime-error', (request, response) => {
// Used to report back any client-side (runtime) errors
router.post('/runtime-error', express.json(), (request, response) => {
if (request.body?.error) {
logger.error('Runtime error! Check your browser console.');
logger.error(request.body.error.stack || request.body.message);
logger.error(request.body.error.stack || request.body.message || request.body);
if (request.body.origin === 'manager') clearManagerCache(options.cache);
}
response.sendStatus(200);
Expand Down Expand Up @@ -373,9 +374,6 @@ export async function storybookDevServer(options: any) {
options.extendServer(server);
}

// Used to report back any client-side (runtime) errors
app.use(express.json());

app.use((req, res, next) => {
res.header('Access-Control-Allow-Origin', '*');
res.header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept');
Expand Down