Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation - Update disable config #12949

Closed
wants to merge 1 commit into from
Closed

Documentation - Update disable config #12949

wants to merge 1 commit into from

Conversation

mad-gav
Copy link

@mad-gav mad-gav commented Oct 29, 2020 •
edited

Amend disable to disabled

Issue:

using 'disable' breaks build

What I did

changed the property to disabled

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@mad-gav
Update disable config
4503a0b 
Amend ```disable``` to ```disabled```
@mad-gav mad-gav changed the title Update disable config Documentation - Update disable config Oct 29, 2020
@shilman
Copy link
Member

shilman commented Nov 1, 2020

Thanks for the fix. This was a bug with the code, not the documentation and has been already fixed here #12603

@shilman shilman closed this Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mad-gav @shilman