CLI: Deprecate '--story-format=mdx' option #12905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooppaaa
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
shilman
approved these changes
Oct 25, 2020
There was a problem hiding this comment.
Looks good except for the warning. Also, the template generates docs-only MDX -- it does not actually generate MDX stories.
I also wonder how to better support people who want to write MDX, e.g. https://twitter.com/preshonyee/status/1319466429595398145. The out of box experience is pretty terrible for people who want to use MDX as their primary syntax. cc @tmeasday @jonniebigodes
Co-authored-by: Michael Shilman <shilman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12285
What I did
Deprecate mdx option
add a warning
How to test
node ../../storybook/lib/cli/dist/generate init --story-format mdx