New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composition: Filter out disabled refs in getAutoRefs #12863
Conversation
Hi @shilman, is there any progress on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
it's possible for an npm package to not contain a package.json?!?! |
@ndelangen They actually have the package.json. The reason I guess is both |
@shilman @ndelangen I noticed the latest changes use typescript and I have already resolved the conflicts. Please check again. |
Issue:
If some packages don鈥榯 export
package.json
, start storybook will warn:What I did
I think to solve this problem we can define these packages in the
refs
and set it as disabled in.storybook/main.js
, like:Then filter out the disabled refs in
getAutoRefs
func. Also, the changed code will reduce the extra disabled refs check than the previous code.I'm not sure if this is correct or reasonable, please help me point out if there is an error, thx. 馃槂
How to test
If your answer is yes to any of these, please make sure to include it in your PR.