Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-knobs: Fix uncontrolled to controlled warning for booleans #12719

Merged
merged 1 commit into from Oct 10, 2020

Conversation

ccpu
Copy link
Contributor

@ccpu ccpu commented Oct 9, 2020

Same as #12322 to fix knob addon

What I did

  • Fixed warning

@shilman shilman added addon: knobs bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 9, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thanks!

@shilman shilman added this to the 6.0.x milestone Oct 9, 2020
@shilman shilman changed the title [Addon-knob] Fix uncontrolled to controlled warning for booleans Addon-knobs: Fix uncontrolled to controlled warning for booleans Oct 10, 2020
@shilman shilman merged commit 7a4cbb3 into storybookjs:next Oct 10, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 10, 2020
shilman added a commit that referenced this pull request Oct 10, 2020
Addon-knobs: Fix uncontrolled to controlled warning for booleans
@ccpu ccpu deleted the patch-1 branch October 13, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants