Misc: Clean usage and place in the monorepo of some dependencies #12653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dev` tag was used for `aurelia` dep in both: - `@storybook/aurelia` - `aurelia-kitchen-sink` A new version is published with this tag multiples a week. But there is no real benefit for us to use a non "stable" version. So I set the version to the 0.7.0 (latest stable as of today). If we need/want to test against `dev` version of aurelia when can setup a specific E2E test.
gaetanmaisse
requested review from
alterx,
igor-dv and
thomasbertet
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR contains commits related to dependency changes extracted from #12315 in order to have no production code changes in the CI PR.
Sum up:
package.jsonto sub packages as they are only used in themcodelyzeras it looks unused for a whileHow to test