Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-docs: Fix exotic React components in Source block #12638

Merged
merged 10 commits into from Oct 5, 2020
Merged

Addon-docs: Fix exotic React components in Source block #12638

merged 10 commits into from Oct 5, 2020

Commits on Oct 1, 2020

  1. fix(react/jsxDecorator): make rendered component's displayName work w… 

    …/ memo & forwardRef exotic components

Prev. would just do as <[object Object]>.. because it didn't know where to lookup the inner render function's name.
    @andezzat
    andezzat committed Oct 1, 2020
    Copy the full SHA
    73369c2 View commit details
    Browse the repository at this point in the history

  2. fix(addon-docs): add any types to props so it builds

    @andezzat
    andezzat committed Oct 1, 2020
    Copy the full SHA
    77ec4c6 View commit details
    Browse the repository at this point in the history

  3. Delete .vscode settings (woops!)

    @andezzat
    andezzat committed Oct 1, 2020
    Copy the full SHA
    f48d5e5 View commit details
    Browse the repository at this point in the history

  4. fix versions

    @ndelangen
    ndelangen committed Oct 1, 2020
    Copy the full SHA
    1b3e3f4 View commit details
    Browse the repository at this point in the history

  5. fix snapshot

    @ndelangen
    ndelangen committed Oct 1, 2020
    Copy the full SHA
    5414c8b View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. Add React.memo dynamic snippet to official-storybook

    @shilman
    shilman committed Oct 3, 2020
    Copy the full SHA
    f80bc26 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. fix(official-storybook): fix displayName for memo & add forward-ref e… 

    …xample

Component should be fed directly to React.memo|forwardRef functions so that displayName is set. Previously was passing an anonymous arrow fn...
    @andezzat
    andezzat committed Oct 5, 2020
    Copy the full SHA
    1b7f550 View commit details
    Browse the repository at this point in the history

  2. fix(official-storybook): use existing forward-ref story

    @andezzat
    andezzat committed Oct 5, 2020
    Copy the full SHA
    2c63dc6 View commit details
    Browse the repository at this point in the history

  3. fix(official-storybook): cleanup

    @andezzat
    andezzat committed Oct 5, 2020
    Copy the full SHA
    861e9b0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'next' into fix/react-component-name

    @shilman
    shilman committed Oct 5, 2020
    Copy the full SHA
    b39e816 View commit details
    Browse the repository at this point in the history