New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-backgrounds: Add docs support and extend grid configuration #12368
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
47ff571
fix(grid-selector): apply grid to the preview body
yannbf 4d1337d
feat(background-selector): rewrite addon in the new syntax
yannbf f57a2be
feat(addon-backgrounds): make grid available in canvas and docs
yannbf be96371
feat(api): deepEqual check before updating globals
yannbf 060f363
feat(backgrounds): turn grid and background to decorators
yannbf 97277fd
chore: update backgrounds examples in official storybook
yannbf 530575b
fix(backgrounds-grid): set correct addon title
yannbf 880f664
test: add support command to get canvas element
yannbf 09bd72b
test(addons): e2e tests for backgrounds and grid
yannbf 879db65
docs(addon-backgrounds): add docs about grid
yannbf 06dd6b6
docs(MIGRATION): deprecation for grid parameter
yannbf bc90fab
fix(backgrounds): apply styles in correct order
yannbf 3336726
fix(components): make docs take full height
yannbf c0f7d5d
docs(backgrounds): use correct snippet path
yannbf c064db4
cli(e2e): add clean slate option
yannbf 9e89143
test(e2e): add canvas body element selector
yannbf 6c1bb7c
docs(MIGRATION): add more default grid parameters
yannbf File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yannbf sorry to disturb you, but I can't understand why emitting of
EVENTS.UPDATE
was removed?In my case I want to run some code when changing background. Previously I used the event introduced in #6561
Maybe you know is there any other way to track background change with code?
Thanks for you answer in advance!