Send story context to transform source #12327
Conversation
NikkiTheBugSlayer
requested review from
ndelangen,
shilman and
stijnkoopal
as code owners
| const { source } = baseContext.parameters.docs; | ||
| const parameters = { ...baseContext.parameters, docs: { source, transformSource } }; | ||
| expect(enhanceSource({ ...baseContext, parameters })).toBeNull(); | ||
| }); | ||
| it('receives StoryContext as second argument', () => { |
There was a problem hiding this comment.
can we test this with a single test instead of three?
There was a problem hiding this comment.
I removed the extra tests.
There was a problem hiding this comment.
Thanks for this contribution @UX-Unicorn! I prefer @phated 's breaking solution -- this API is brand new I don't think enough people are using it yet, so I'm going to make a semver exception and merge that PR instead. Sorry for making you update the tests, I didn't fully understand the PR until I'd read all the related PRs at once.
@shilman That makes sense. I just didn't want to have to wait for the breaking change to get merged to get access to the context in transformSource. |
Issue:
What I did
This is similar to #12265 , but sends the context to transformSource as third argument so it is not a breaking change. This is useful for updating the source block when a users changes the controls.
How to test
I created the button-with-custom-source-code story to demonstrate how context can be used in transformSource. I also updated enhanceSource to test everything was being sent correctly.