[manager] Change API to disable composition #12326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndelangen if this is indeed a typo we should probably fix the feature to accept |
- `refs[key].disabled` -> `refs[key].disable`
|
Thanks, @shilman. That's a much better way forward. I went ahead and pushed a commit to the branch that reverts the prior commit and changes the code in question. |
ndelangen
approved these changes
Aug 31, 2020
kylegach
changed the title
|
Closing because this was superseded by #12603. |
|
Thanks @kylegach! So sorry I missed this ... sometimes it's like drinking from a firehose 😭 |
|
No worries! It happens. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: API to disable composition of a Storybook is incorrect, as it uses
disabledinstead ofdisable.What I did
refs[key].disabled->refs[key].disableHow to test
Try to disable composition. Not sure if this needs tests, or how to test it.