Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use options parameter from first story on init. #11937

Closed
wants to merge 2 commits into from
Closed

Use options parameter from first story on init. #11937

wants to merge 2 commits into from

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Aug 12, 2020 •
edited

Issue: #11924

What I did

Use the full parameters of the first story (which is what we did on story change anyway), on init.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    Yes, we have tests

@tmeasday tmeasday requested a review from shilman August 12, 2020 13:20
@tmeasday tmeasday changed the title 11892 local refs Use options parameter from first story on init. Aug 12, 2020
@github-actions
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 7dad7b2

@tmeasday
Copy link
Member Author

Whoops, this accidentally included a different branch. Reopening

@tmeasday tmeasday closed this Aug 12, 2020
@stof stof deleted the 11892-local-refs branch May 25, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tmeasday