Vue: Add support for tsx #11936
Merged
Vue: Add support for tsx #11936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change vue file paths get `ts` suffix. However; if using `<script lang="tsx">` we want `tsx` to be the suffix, this change adds `tsx` as a test rule and applies `appendTsxSuffixTo`
|
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Nx Cloud ReportCI ran the following commands for commit 618fc1c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
approved these changes
Jul 19, 2021
There was a problem hiding this comment.
Merging w/ help from @Aaron-Pool. Thanks for your patience!! 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change vue file paths get
tssuffix. However; if using<script lang="tsx">we wanttsxto be the suffixWhat I did
This change adds
tsxas a test rule and appliesappendTsxSuffixTo.How to test