CLI: Support TSX in storiesof-to-csf migration #11107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vanuan
reviewed
Jun 10, 2020
| @@ -13,3 +13,6 @@ export const sanitizeName = (name) => { | |||
| } | |||
| return key; | |||
| }; | |||
|
|
|||
| export const prettierParser = (parser) => | |||
There was a problem hiding this comment.
Maybe jscodeshiftToPrettierParser.
And use a map:
const parserMap = {
'babylon': 'babel',
'flow': 'flow',
'ts': 'typescript',
'tsx': 'typescript'
};
return parserMap[parser] || 'babel';
|
This doesn't add a test.. Can we add one and verify this actually works? |
|
Is this merged? Is there a different PR? |
|
@Vanuan no, i tried it out but there are more changes that need to happen and I don't have time to follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #9669
What I did
Quick & dirty fix based on @Vanuan 's suggestion
How to test
Run
storiesof-to-csfmigration on TSX project (untested)