Addon-docs: Fix story inline rendering #10875
Merged
+8
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
This cleans up some old code that existed before
prepareForInlinewas introduced in SB5.3 for handling non-react inline rendering. So it's mostly a maintenance PR.However, it also fixes a bug that @matheo caught in #10850 that also affects this codepath.
Now all inline rendering is defined by the docs preset or user overrides, and there is no longer any hacky react-specific inference. Technically this is a breaking change but only in the case where you're not using a preset (which at this point, I hope is nobody).
How to test
View
Docstab inofficial-storybook,angular-cli,vue-kitchen-sink, etc.