Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Add globalArgs/globalArgTypes preview.js exports #10123

Merged
merged 3 commits into from Mar 13, 2020
Merged

Core: Add globalArgs/globalArgTypes preview.js exports #10123

merged 3 commits into from Mar 13, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 13, 2020

Issue: N/A

What I did

  • Added globalArgs/globalArgTypes support for preview.js
  • Added test/example
  • documentation?
  • store globalArgTypes and make it accessible?

How to test

See attached tests and Global Args stories in official-storybook

@shilman shilman added this to the 6.0.0 milestone Mar 13, 2020
tmeasday
tmeasday approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Do you want to also do in this PR (or another?)

  1. Warn if adding non-global globalArgs or globalArgTypes parameters,
  2. Warn if exporting args or argTypes from preview.js
  3. Warn if adding global parameters for args / argTypes ?

@shilman shilman changed the title Core: Add globalArgs/globalArgTypes exports to preview.js Core: Add globalArgs/globalArgTypes preview.js exports Mar 13, 2020
@shilman
Copy link
Member Author

shilman commented Mar 13, 2020

@tmeasday good call! will add 👍

@shilman shilman merged commit e75d6d4 into next Mar 13, 2020
@shilman shilman deleted the feature/global-args-exports branch March 13, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@usulpro usulpro Awaiting requested review from usulpro

Assignees
No one assigned
Labels
core feature request
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shilman @tmeasday @ndelangen