Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鈥硷笍 馃洃 Composition is broken in Safari (desktop and mobile) #15920

Closed
tim-mukhin opened this issue Aug 25, 2021 · 5 comments
Closed

Comments

@tim-mukhin
Copy link

tim-mukhin commented Aug 25, 2021

Hi!
Could you please fix this issue. It's blocker for us. Most of our developers in company use Macbooks and many of them use Safari.

Describe the bug
The Composition on Safari browser (desktop and mobile) is broken. See the reproducing steps.

To Reproduce

  1. First option with official storybook
    Steps:
  • Open official storybook from the docs.
  • Scroll down on the left panel to external storybook, open any story, wait until it loads and select the Docs tab

image

  • Scroll stories back to top and choose any story from the current storybook
  • Now the docs tab will stuck with docs from external storybook

image

  1. Second option with repro repository
  • Clone this repo
  • Install dependencies
  • Start storybook with yarn storybook
  • Scroll down on the left panel to external storybook sample2, open any story, wait until it loads and select the Docs tab

image

  • Scroll stories back to top and choose any story from the current storybook
  • Now you can see "No docs" block on any docs page

image

  • And after that you can also reproduce the issue from first oprion if you open external 'Official storybook'

System

System:
    OS: macOS 11.5
    CPU: (8) arm64 Apple M1
  Binaries:
    Node: 14.17.4 - ~/.nvm/versions/node/v14.17.4/bin/node
    Yarn: 3.0.1 - ~/.nvm/versions/node/v14.17.4/bin/yarn
    npm: 6.14.14 - ~/.nvm/versions/node/v14.17.4/bin/npm
  Browsers:
    Edge: 92.0.902.78
    Firefox: 90.0.2
    Safari: 14.1.2
  npmPackages:
    @storybook/addon-actions: ^6.4.0-alpha.32 => 6.4.0-alpha.32 
    @storybook/addon-docs: ^6.4.0-alpha.32 => 6.4.0-alpha.32 
    @storybook/addon-essentials: ^6.4.0-alpha.32 => 6.4.0-alpha.32 
    @storybook/addon-links: ^6.4.0-alpha.32 => 6.4.0-alpha.32 
    @storybook/node-logger: ^6.4.0-alpha.32 => 6.4.0-alpha.32 
    @storybook/preset-create-react-app: ^3.2.0 => 3.2.0 
    @storybook/react: ^6.4.0-alpha.32 => 6.4.0-alpha.32 

Additional context
The issue also reprodusable on MacOS Catalina and iOS 14

@tim-mukhin
Copy link
Author

@shilman

Hi!
Could you please consider this issue 馃檹
It's a blocker for us

@tim-mukhin tim-mukhin changed the title Composition is broken in Safari (desktop and mobile) 鈥硷笍 馃洃 Composition is broken in Safari (desktop and mobile) Sep 21, 2021
@shilman
Copy link
Member

shilman commented Sep 29, 2021

@tim-mukhin we're looking at composition again as part of a giant performance refactor that's happening in 6.4, so I'll try to squeeze this in.

@shilman
Copy link
Member

shilman commented Mar 17, 2022

Boo-yah!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.0-alpha.49 containing PR #17679 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 17, 2022
@shilman
Copy link
Member

shilman commented Apr 1, 2022

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.20 containing PR #17679 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

@tim-mukhin
Copy link
Author

Yay! Many thanks! Already upgrading and testing 馃コ馃コ馃コ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants