UI: Fix composition support in safari #17679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f61263f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
added
bug
patch:yes
shilman
changed the title
shilman
deleted the
norbert/ch-1636-storybook-composition-ref-is-shown-when
branch
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Apr 1, 2022
…composition-ref-is-shown-when UI: Fix composition support in safari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15920
What I did
I changed the way of hiding frames from using css
visibilityproperty, to usingdisplay: none|blockThis is relevant for refs / composition.
The problem was that visibility:hidden is sometimes used by click-jacking attempt, and thus safari protects the user by ignoring the css, when the frames are cross-origin.
By changing the use to
display:none, the element is no longer a click-target.How to test