Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Starting with cached manager now shows " for manager" in boot confirmation #13292

Closed
ghengeveld opened this issue Nov 26, 2020 · 1 comment
Closed

CLI: Starting with cached manager now shows " for manager" in boot confirmation #13292

ghengeveld opened this issue Nov 26, 2020 · 1 comment
Assignees
@ghengeveld
Labels
bug cli

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Nov 26, 2020 •
edited

This is a regression that happened while fixing some types. managerTotalTime used to be 0 and thereby falsy, so it wouldn't be printed. Recently this changed to [0,0] to be a valid hrtime, but this is truthy, causing an empty string to be printed followed by the " for manager" label.

Screenshot 2020-11-26 at 14 12 26
@ghengeveld ghengeveld self-assigned this Nov 26, 2020
@ghengeveld ghengeveld mentioned this issue Nov 26, 2020
Merged
@ghengeveld ghengeveld changed the title Core: Starting with cached manager now shows " for manager" in boot confirmation CLI: Starting with cached manager now shows " for manager" in boot confirmation Nov 26, 2020
@shilman
Copy link
Member

shilman commented Nov 26, 2020

¡Ay Caramba!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.7 containing PR #13294 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghengeveld ghengeveld

Labels
bug cli
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghengeveld @shilman