Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook-static: toolbar 'open canvas in new tab' has wrong url: storybook-static/index.htmliframe.html #12162

Closed
davidhildering opened this issue Aug 20, 2020 · 2 comments
Assignees
Milestone

Comments

@davidhildering
Copy link

davidhildering commented Aug 20, 2020

Describe the bug
I just migrated from 5.3 to 6.014. Now, if I npm run build-storybook and check storybook-static, the link set for the 'open canvas in new tab' is wrong.

output: storybook-static/index.htmliframe.html?id=
what it should be: storybook-static/iframe.html?id=

my version:
"@babel/preset-react": "^7.9.4",
"@storybook/addon-a11y": "^6.0.6",
"@storybook/addon-backgrounds": "latest",
"@storybook/addon-knobs": "latest",
"@storybook/addon-links": "latest",
"@storybook/addon-storyshots": "latest",
"@storybook/addons": "latest",
"@storybook/components": "latest",
"@storybook/preset-create-react-app": "3.1.4",
"@storybook/preset-scss": "^1.0.2",
"@storybook/react": "^6.0.14",
"@storybook/theming": "^6.0.6",

  1. npm run build-storybook
  2. open storybook-static/index.html
  3. click on open canvas in new tab
  4. result

Expected behavior
a correct url

System:
windows10, storybook-react

@shilman
Copy link
Member

shilman commented Aug 26, 2020

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.19 containing PR #12233 that references this issue. Upgrade today to try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants