Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix eject and copy URLs for composition #12233

Merged
merged 1 commit into from Aug 26, 2020

Conversation

ndelangen
Copy link
Member

Issue: #12162

What I did

I changed the eject 7 copy feature so it has the correct url, same implementation as in the preview.

how to test

  • navigate to a storybook
  • ensure there's index.html in manager
  • click eject in toolbar

@davidhildering would you be able to review?

@ndelangen ndelangen added this to the 6.0.x milestone Aug 25, 2020
@ndelangen ndelangen requested a review from shilman August 25, 2020 08:23
@ndelangen ndelangen self-assigned this Aug 25, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👏

@shilman shilman changed the title FIX #12162 by setting the baseUrl correctly UI: Fix eject and copy URLs for composition Aug 26, 2020
@shilman shilman merged commit 4fcf339 into next Aug 26, 2020
@ndelangen ndelangen deleted the fix/12162-correct-baseUrl-copy-eject branch August 26, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants