avoid potentially slow regex call in renderJsx

storybookjs · Jul 14, 2021 · f001b11 · f001b11
1 parent dc390b8
commit f001b11
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/addons/docs/src/frameworks/react/jsxDecorator.tsx b/addons/docs/src/frameworks/react/jsxDecorator.tsx
@@ -115,12 +115,14 @@ export const renderJsx = (code: React.ReactElement, options: JSXOptions) => {
     // @ts-ignore FIXME: workaround react-element-to-jsx-string
     const child = typeof c === 'number' ? c.toString() : c;
     let string = applyBeforeRender(reactElementToJSXString(child, opts as Options), options);
-    const matches = string.match(/\S+=\\"([^"]*)\\"/g);
 
-    if (matches) {
-      matches.forEach((match) => {
-        string = string.replace(match, match.replace(/&quot;/g, "'"));
-      });
+    if (string.indexOf('&quot;') > -1) {
+      const matches = string.match(/\S+=\\"([^"]*)\\"/g);
+        if (matches) {
+          matches.forEach((match) => {
+            string = string.replace(match, match.replace(/&quot;/g, "'"));
+          });
+        }
     }
 
     return string;