Merge pull request #15409 from storybookjs/revert-15168-vue3-update-a…

…rgs-without-remount Revert "Vue3: Update args without re-mounting component"
storybookjs · Jun 29, 2021 · c2d2ca1 · c2d2ca1
2 parents c6d7323 + 005ae1a
commit c2d2ca1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/app/vue3/src/client/preview/index.ts b/app/vue3/src/client/preview/index.ts
@@ -41,7 +41,7 @@ function prepare(rawStory: StoryFnVueReturnType, innerStory?: ConcreteComponent)
 
   return {
     render() {
-      return h(story, this.$root.storyArgs);
+      return h(story);
     },
   };
 }

diff --git a/app/vue3/src/client/preview/render.ts b/app/vue3/src/client/preview/render.ts
@@ -1,28 +1,17 @@
 import dedent from 'ts-dedent';
 import { createApp, h, shallowRef, ComponentPublicInstance } from 'vue';
-import { Args } from '@storybook/addons';
 import { RenderContext, StoryFnVueReturnType } from './types';
 
 const activeStoryComponent = shallowRef<StoryFnVueReturnType | null>(null);
 
-interface Root extends ComponentPublicInstance {
-  storyArgs?: Args;
-}
-
-let root: Root | null = null;
+let root: ComponentPublicInstance | null = null;
 
 export const storybookApp = createApp({
   // If an end-user calls `unmount` on the app, we need to clear our root variable
   unmounted() {
     root = null;
   },
 
-  data() {
-    return {
-      storyArgs: undefined,
-    };
-  },
-
   setup() {
     return () => {
       if (!activeStoryComponent.value)
@@ -59,13 +48,9 @@ export default function render({
 
   showMain();
 
-  if (!forceRender) {
-    activeStoryComponent.value = element;
-  }
+  activeStoryComponent.value = element;
 
   if (!root) {
     root = storybookApp.mount('#root');
   }
-
-  root.storyArgs = args;
 }