Merge pull request #13308 from storybookjs/13273/fix-hash-dropping

Core: Fix preview URL dropped hashes
storybookjs · Nov 27, 2020 · b9dde89 · b9dde89
2 parents f336ea8 + 2edf841
commit b9dde89
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/lib/core/src/client/preview/url.test.ts b/lib/core/src/client/preview/url.test.ts
@@ -42,6 +42,16 @@ describe('url', () => {
         'pathname?foo=bar&id=story--id&viewMode=story'
       );
     });
+    it('should ignore + keep hashes', () => {
+      document.location.search = 'foo=bar&selectedStory=selStory&selectedKind=selKind';
+      document.location.hash = '#foobar';
+      setPath({ storyId: 'story--id', viewMode: 'story' });
+      expect(history.replaceState).toHaveBeenCalledWith(
+        {},
+        '',
+        'pathname?foo=bar&id=story--id&viewMode=story#foobar'
+      );
+    });
   });
 
   describe('parseQueryParameters', () => {

diff --git a/lib/core/src/client/preview/url.ts b/lib/core/src/client/preview/url.ts
@@ -19,14 +19,15 @@ export const setPath = (selection?: StoreSelection) => {
   }
 
   const { storyId, viewMode }: { storyId: StoryId; viewMode: ViewMode } = selection;
-  const { path, selectedKind, selectedStory, ...rest } = qs.parse(document.location.search, {
+  const { search, hash } = document.location;
+  const { path, selectedKind, selectedStory, ...rest } = qs.parse(search, {
     ignoreQueryPrefix: true,
   });
   const newPath = `${document.location.pathname}?${qs.stringify({
     ...rest,
     id: storyId,
     viewMode,
-  })}`;
+  })}${hash || ''}`;
   history.replaceState({}, '', newPath);
 };