Merge pull request #13288 from leettaylor/lt/fix/vue-source

Addon-docs: Fix Vue source snippets for function attributes
storybookjs · Nov 27, 2020 · 813b4dd · 813b4dd
2 parents 8b29285 + 7589650
commit 813b4dd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/addons/docs/src/frameworks/vue/sourceDecorator.test.ts b/addons/docs/src/frameworks/vue/sourceDecorator.test.ts
@@ -32,7 +32,7 @@ describe('vnodeToString', () => {
 
   it('attributes', () => {
     const MyComponent: ComponentOptions<any, any, any> = {
-      props: ['propA', 'propB', 'propC', 'propD'],
+      props: ['propA', 'propB', 'propC', 'propD', 'propE', 'propF', 'propG'],
       template: '<div/>',
     };
 
@@ -49,14 +49,21 @@ describe('vnodeToString', () => {
                 propD: {
                   foo: 'bar',
                 },
+                propE: true,
+                propF() {
+                  const foo = 'bar';
+
+                  return foo;
+                },
+                propG: undefined,
               },
             };
           },
           template: `<my-component v-bind="props"/>`,
         })
       )
     ).toMatchInlineSnapshot(
-      `<my-component :propD='{"foo":"bar"}' :propC="null" :propB="1" propA="propA"/>`
+      `<my-component propE :propD='{"foo":"bar"}' :propC="null" :propB="1" propA="propA"/>`
     );
   });
 

diff --git a/addons/docs/src/frameworks/vue/sourceDecorator.ts b/addons/docs/src/frameworks/vue/sourceDecorator.ts
@@ -123,7 +123,7 @@ export function vnodeToString(vnode: Vue.VNode): string {
 }
 
 function stringifyAttr(attrName: string, value?: any): string | null {
-  if (typeof value === 'undefined') {
+  if (typeof value === 'undefined' || typeof value === 'function') {
     return null;
   }