Skip to content

Commit

Permalink
added in configuration change to stats
Browse files Browse the repository at this point in the history
  • Loading branch information
dhuang612 committed Oct 14, 2019
1 parent 4751e49 commit 7a28fba
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 9 deletions.
9 changes: 1 addition & 8 deletions lib/core/src/server/build-static.js
Expand Up @@ -130,15 +130,12 @@ async function buildManager(configType, outputDir, configDir, options) {
if (options.debugWebpack) {
logConfig('Manager webpack config', managerConfig);
}
if (options.stats.errorDetails) {
logConfig('Manager webpack config', managerConfig);
}

return compileManager(managerConfig, managerStartTime);
}

async function buildPreview(configType, outputDir, packageJson, options) {
const { watch, debugWebpack, errorDetails } = options;
const { watch, debugWebpack } = options;

logger.info('=> Building preview..');
const previewStartTime = process.hrtime();
Expand All @@ -153,10 +150,6 @@ async function buildPreview(configType, outputDir, packageJson, options) {
...options,
});

if (errorDetails) {
logConfig('Show verbose errors', previewConfig);
}

if (debugWebpack) {
logConfig('Preview webpack config', previewConfig);
}
Expand Down
1 change: 0 additions & 1 deletion lib/core/src/server/cli/dev.js
Expand Up @@ -29,7 +29,6 @@ async function getCLI(packageJson) {
.option('--quiet', 'Suppress verbose build output')
.option('--no-dll', 'Do not use dll reference')
.option('--debug-webpack', 'Display final webpack configurations for debugging purposes')
.option('--display-error-details', 'Show errors')
.option(
'--preview-url [string]',
'Disables the default storybook preview and lets your use your own'
Expand Down
1 change: 1 addition & 0 deletions lib/core/src/server/dev-server.js
Expand Up @@ -53,6 +53,7 @@ export default function(options) {
error.error = err;
error.close = true;
error.stats = stats;
stats.toJson(options.errorDetails);
logger.line();
logger.line();
try {
Expand Down

0 comments on commit 7a28fba

Please sign in to comment.