Merge pull request #14494 from storybookjs/no-docs-args

Core: Don't include args param in docs mode URL
storybookjs · Apr 7, 2021 · 5a9cd8a · 5a9cd8a
2 parents e9d2dd4 + 6d54805
commit 5a9cd8a
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/lib/api/src/modules/url.ts b/lib/api/src/modules/url.ts
@@ -8,7 +8,6 @@ import { window } from 'global';
 import { ModuleArgs, ModuleFn } from '../index';
 import { PanelPositions } from './layout';
 import { isStory } from '../lib/stories';
-import type { Story } from '../lib/stories';
 
 interface Additions {
   isFullscreen?: boolean;
@@ -150,25 +149,30 @@ export const init: ModuleFn = ({ store, navigate, state, provider, fullAPI, ...r
 
   const initModule = () => {
     // Sets `args` parameter in URL, omitting any args that have their initial value or cannot be unserialized safely.
-    const updateArgsParam = (args?: Story['args']) => {
+    const updateArgsParam = () => {
+      const { path, viewMode } = fullAPI.getUrlState();
+      if (viewMode !== 'story') return;
+
       const currentStory = fullAPI.getCurrentStoryData();
-      const initialArgs = (isStory(currentStory) && currentStory.initialArgs) || {};
+      if (!isStory(currentStory)) return;
+
+      const { args, initialArgs } = currentStory;
       const argsString = buildArgsParam(initialArgs, args);
       const argsParam = argsString.length ? `&args=${argsString}` : '';
-      queryNavigate(`${fullAPI.getUrlState().path}${argsParam}`, { replace: true });
+      queryNavigate(`${path}${argsParam}`, { replace: true });
       api.setQueryParams({ args: argsString });
     };
 
     fullAPI.on(SET_CURRENT_STORY, () => updateArgsParam());
 
     let handleOrId: any;
-    fullAPI.on(STORY_ARGS_UPDATED, ({ args }) => {
+    fullAPI.on(STORY_ARGS_UPDATED, () => {
       if ('requestIdleCallback' in window) {
         if (handleOrId) window.cancelIdleCallback(handleOrId);
-        handleOrId = window.requestIdleCallback(() => updateArgsParam(args), { timeout: 1000 });
+        handleOrId = window.requestIdleCallback(updateArgsParam, { timeout: 1000 });
       } else {
         if (handleOrId) clearTimeout(handleOrId);
-        setTimeout(updateArgsParam, 100, args);
+        setTimeout(updateArgsParam, 100);
       }
     });