fix: handle cases where there is no stats to write for the manager

Also strengthen the checks for the preview part and improve types.
storybookjs · Nov 24, 2020 · 4d19f7e · 4d19f7e
1 parent cbf8f4c
commit 4d19f7e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/lib/core/src/server/build-dev.ts b/lib/core/src/server/build-dev.ts
@@ -218,11 +218,13 @@ function outputStartupInformation(options: {
   );
 }
 
-async function outputStats(previewStats: Stats, managerStats: Stats) {
+async function outputStats(previewStats: Stats | undefined, managerStats: Stats | undefined) {
   if (previewStats) {
     await writeStats('preview', previewStats);
   }
-  await writeStats('manager', managerStats);
+  if (managerStats) {
+    await writeStats('manager', managerStats);
+  }
   logger.info(
     `stats written to => ${chalk.cyan(resolvePathInStorybookCache('public/[name].json'))}`
   );
@@ -282,9 +284,9 @@ export async function buildDevStandalone(
 
     if (options.smokeTest) {
       await outputStats(previewStats, managerStats);
-      const managerWarnings = (managerStats as any).toJson().warnings.length > 0;
+      const managerWarnings = !!managerStats && managerStats.toJson().warnings.length > 0;
       const previewWarnings =
-        !options.ignorePreview && (previewStats as any).toJson().warnings.length > 0;
+        !options.ignorePreview && !!previewStats && previewStats.toJson().warnings.length > 0;
       process.exit(managerWarnings || previewWarnings ? 1 : 0);
       return;
     }

diff --git a/lib/core/src/server/dev-server.ts b/lib/core/src/server/dev-server.ts
@@ -256,7 +256,7 @@ const startManager = async ({
   }
 
   if (!managerConfig) {
-    return { managerStats: {}, managerTotalTime: [0, 0] } as ManagerResult;
+    return { managerTotalTime: [0, 0] };
   }
 
   const compiler = webpack(managerConfig);
@@ -309,7 +309,7 @@ const startPreview = async ({
   outputDir,
 }: any): Promise<PreviewResult> => {
   if (options.ignorePreview) {
-    return { previewStats: {}, previewTotalTime: [0, 0] } as PreviewResult;
+    return { previewTotalTime: [0, 0] };
   }
 
   const previewConfig = await loadConfig({

diff --git a/lib/core/src/server/types.ts b/lib/core/src/server/types.ts
@@ -94,12 +94,12 @@ export interface ReleaseNotesData {
 }
 
 export interface PreviewResult {
-  previewStats: Stats;
+  previewStats?: Stats;
   previewTotalTime: [number, number];
 }
 
 export interface ManagerResult {
-  managerStats: Stats;
+  managerStats?: Stats;
   managerTotalTime: [number, number];
 }