Merge pull request #17174 from storybookjs/17128-fix-process-env-assi…

…gnment Core: Fix process.env assignment
storybookjs · Jan 10, 2022 · 2bc5614 · 2bc5614
1 parent 72a6d69
commit 2bc5614
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/examples/react-ts/.env b/examples/react-ts/.env
@@ -0,0 +1 @@
+FOO=bar
diff --git a/examples/react-ts/src/button.stories.tsx b/examples/react-ts/src/button.stories.tsx
@@ -27,6 +27,13 @@ export const StoryNoRender = {
   args: { label: 'magic!' },
 };
 
+export const ProcessEnv = {
+  args: { label: process.env.FOO },
+  play: () => {
+    process.env.BAZ = 'moo';
+  },
+};
+
 export const StoryWithPlay = {
   args: { label: 'play' },
   play: () => {

diff --git a/lib/core-common/src/utils/envs.ts b/lib/core-common/src/utils/envs.ts
@@ -59,8 +59,12 @@ export const stringifyProcessEnvs = (raw: Record<string, string>): Record<string
       'process.env.XSTORYBOOK_EXAMPLE_APP': '""',
     }
   );
-  // support destructuring like
+  // FIXME: something like this is necessary to support destructuring like:
+  //
   // const { foo } = process.env;
-  envs['process.env'] = JSON.stringify(raw);
+  //
+  // However, it also means that process.env.foo = 'bar' will fail, so removing this:
+  //
+  // envs['process.env'] = JSON.stringify(raw);
   return envs;
 };