fix: types was included in the .js file output using the useJs option in sb-rn-get-stories
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when the useJs option is used
grgr-dkrk
force-pushed
the
fix/v7_getStories_useJsOption
branch
from
d9cb32b
to
d7ba672
Compare
|
Thanks for the contribution will get to this soon :) |
|
whilst it does work without the type I added this type specifically because some stricter typescript settings would complain about the type being any. I've adjusted it to make it not generate that type if using js and added tests for js generation. |
|
thanks again for raising this issue and your contribution :) |
|
@grgr-dkrk just published this on 7.6.18 please try it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: none
What I did
The
.jsfile output using theuseJsoption withsb-rn-get-storiescontained types.This PR fixes that.
The type of args of
importFnis defined in @storybook/preview-api, so I deleted the definition in this file.How to test
I verified that there are no type errors in the output
.jsfile.