Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add optional chaining to object property key #80

Merged
merged 2 commits into from Feb 17, 2022
Merged

fix: add optional chaining to object property key #80

merged 2 commits into from Feb 17, 2022

Conversation

aurmer
Copy link
Contributor

@aurmer aurmer commented Feb 16, 2022

Issue: #78

What Changed

  • add optional chaining to the handling of MetaObjectExpression properties to prevent type exception when not of type Property.
  • add a few test cases to help validate more syntactically valid cases
  • minor text update to CONTRIBUTING.md

Checklist

Check the ones applicable to your change:

  • Ran yarn update-all
  • Tests are updated
  • Documentation is updated

Change Type

Indicate the type of change your pull request is:

  • maintenance
  • documentation
  • patch
  • minor
  • major

@yannbf yannbf added the patch Increment the patch version when merged label Feb 17, 2022
@yannbf
Copy link
Member

yannbf commented Feb 17, 2022

Hey @aurmer thanks a lot for this contribution! Great stuff <3

@yannbf yannbf merged commit bfb98ce into storybookjs:main Feb 17, 2022
@github-actions
Copy link

🚀 PR was released in v0.5.7 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aurmer @yannbf