Add .storybook to server.fs.allow

[benmccann]

Closes #426

[IanVS]

Thanks for the PR. Do you know why this might be necessary? With my understanding of the fs.strict config option (https://vitejs.dev/config/#server-fs-strict), files and folders inside the root should be allowed by default. Is this maybe a bug in vite?

[benmccann]

I think the docs are wrong. As soon as you specify one directory in the allow list it no longer allows the workspace root:

https://github.com/vitejs/vite/blob/f280dd99856af68a47635dda609c402333805209/packages/vite/src/node/server/index.ts#L683

SvelteKit adds directories to the allow list by default, so I think the workspace root would not get added:

https://github.com/sveltejs/kit/blob/0915cb5c1a6edb07ac915c24c69cb47d1d15e3de/packages/kit/src/vite/index.js#L169

[IanVS]

Oh I see, thanks. In that case, I'm reluctant to merge this change, as it would have the same impact for everyone else not using sveltekit who might need files in other directories within the workspace root. I don't suppose the sveltekit vite plugin could re-add the workspace root, so as to restore the default behavior?

[benmccann]

Good point. I've updated this with a new solution that will still work if the user hasn't defined server.fs.allow. We don't want to add the workspace root in SvelteKit as we consider that behavior to be insecure.

[IanVS]

Thanks for the contribution!