Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Vite 3 #394

Merged
merged 9 commits into from Jul 8, 2022
Merged

Support Vite 3 #394

merged 9 commits into from Jul 8, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented May 26, 2022

This updates the vite builder to support vite 3.0, which is a breaking change due to our use of @vitejs/plugin-react, which also has a new major version to support vite 3.

This also updates our examples to the latest vite and vite plugin beta versions.

@IanVS
Copy link
Member Author

IanVS commented May 26, 2022

We're getting an error from memoizerific, which is used in many storybook packages, and has a check for process.env.FORCE_SIMILAR_INSTEAD_OF_MAP. Why was this working before? 🤔

@IanVS
Copy link
Member Author

IanVS commented Jun 16, 2022

Cool, after rebasing on to #410, the examples built successfully in the linux runner. The mac build ran out of memory, but otherwise looked like it would have succeeded.

@@ -17,7 +17,7 @@
"@mdx-js/mdx": "^1.6.22",
"@storybook/csf-tools": "^6.4.3",
"@storybook/source-loader": "^6.4.3",
"@vitejs/plugin-react": "^1.0.8",
"@vitejs/plugin-react": "^2.0.0-alpha.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supporting Vite 3.0 will be a breaking change due to this, since this version will fail with vite < 3.

@IanVS IanVS changed the title Update examples vite to 3.0.0-alpha.4 Support Vite 3 Jun 21, 2022
@IanVS IanVS added the breaking label Jun 21, 2022
@IanVS
Copy link
Member Author

IanVS commented Jun 22, 2022

Building the examples was running out of memory in the macOS runner, and my theory is that it is due to those runners having three cores, and yarn choosing to run two concurrent builds in parallel, which exceeds the memory available to node on those worker boxes. But they have 14gb of memory available, so I'm trying to bump the --max-old-space-size to see if that resolves the issue.

@IanVS IanVS merged commit 9e8e6ec into main Jul 8, 2022
@IanVS IanVS deleted the vite-3 branch July 8, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant