Support CSF3 user settable global render #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have an example of what change this makes? I.e., do we have an example/test of something that fails without this change but passes with it? |
|
Once storybookjs/storybook#17885 is released, will there be other changes needed here, or tests we can perform to confirm this is working as intended? |
IanVS
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Alright, it's been released in alpha.60, and I tested out https://github.com/joshwooding/sb-global-render-repro both without and with the change in this PR, and now I get what's happening. Thanks @joshwooding!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #294