Fix missing types by adding back main and types fields
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
changed the title
main and types fields
JReinhold
changed the title
main and types fieldsmain and types fields
JReinhold
added
bug
|
I'm just testing the canary EDIT: Works, in the repro at least |
JReinhold
approved these changes
Aug 1, 2023
|
Tested locally with canary version, works great. https://github.com/olafurw/addon-svelte-csf-import-bug/actions/runs/5726789194/job/15517919448 Thank you @hobbes7878 and @JReinhold |
|
🚀 PR was released in |
|
Uh that's strange...my fix was working locally...than all of a sudden it stopped working. This seems to have fixed it once and for all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… so TS node10 moduleResolution still works per #116.