Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rulesets): add multiple xor #2614

Merged

Conversation

JeanArhancet
Copy link
Contributor

@JeanArhancet JeanArhancet commented Apr 25, 2024

Closes #2396

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

This PR enhances the XOR core function to support scenarios involving more than two properties, allowing for expanded logical evaluations across multiple attributes.

@JeanArhancet JeanArhancet requested a review from a team as a code owner April 25, 2024 09:09
@JeanArhancet JeanArhancet changed the title feat: add multiple xor feat(rulesets): add multiple xor Apr 25, 2024
@mnaumanali94 mnaumanali94 enabled auto-merge (squash) May 3, 2024 11:42
@mnaumanali94 mnaumanali94 merged commit af9c742 into stoplightio:develop May 3, 2024
9 checks passed
RafaelJCamara pushed a commit to RafaelJCamara/spectral that referenced this pull request May 3, 2024
@cuttingclyde
Copy link

cuttingclyde commented May 3, 2024

@mnaumanali94 , I'm glad to see that this issue (xor functionality limited to 2 properties) has gotten attention and adoption. Please also review my PR #2616 which extends the functionality further--can be 1 property, no maximum limit, and documentation updates--and also adds a similar "or" function.

@cuttingclyde
Copy link

My PR #2616 has now been merged with this PR #2614. "feat(rulesets): add multiple xor", and rest of spectral develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more than 2 logicals in XOR core function
3 participants