Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(asyncapi): Update asyncapi rules with updated AsyncAPI v2 URL. #2613

Closed

Conversation

RafaelJCamara
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Screenshots

Before:
image

After:
image

Additional context

When you go to the AsyncAPI rules, there's a link for the supported AsyncAPI specification version:
image

When you click the existing link, we get the 404 mentioned in the above screenshot.

With this PR, we get a new non-broken link.

@RafaelJCamara RafaelJCamara requested a review from a team as a code owner April 22, 2024 19:57
@mnaumanali94
Copy link
Contributor

@RafaelJCamara Can you please update the commit message with the following conventions: https://github.com/semantic-release/semantic-release

@RafaelJCamara RafaelJCamara changed the title Update asyncapi rules with updated AsyncAPI v2 URL. docs(asyncapi): update asyncapi rules with updated AsyncAPI v2 URL. May 3, 2024
@RafaelJCamara RafaelJCamara changed the title docs(asyncapi): update asyncapi rules with updated AsyncAPI v2 URL. Update asyncapi rules with updated AsyncAPI v2 URL. May 3, 2024
@RafaelJCamara RafaelJCamara changed the title Update asyncapi rules with updated AsyncAPI v2 URL. docs(asyncapi): Update asyncapi rules with updated AsyncAPI v2 URL. May 3, 2024
JeanArhancet and others added 4 commits May 3, 2024 14:48
Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.53 to 0.10.64.
- [Release notes](https://github.com/medikoo/es5-ext/releases)
- [Changelog](https://github.com/medikoo/es5-ext/blob/main/CHANGELOG.md)
- [Commits](medikoo/es5-ext@v0.10.53...v0.10.64)

---
updated-dependencies:
- dependency-name: es5-ext
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nauman <mnaumanali94@gmail.com>
@RafaelJCamara
Copy link
Contributor Author

@mnaumanali94 please check

@RafaelJCamara
Copy link
Contributor Author

Did my best to rename the commit, but the old one seems to be wondering around...

@RafaelJCamara
Copy link
Contributor Author

I'll close this PR and create a new one clean.
new PR: #2618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants